-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular-devkit/build-angular): ensure all build resources are served in esbuild dev server #24975
fix(@angular-devkit/build-angular): ensure all build resources are served in esbuild dev server #24975
Conversation
1f248c1
to
a158dff
Compare
a158dff
to
5456922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a typo in the commit message and serve and such files that were generated during the build process.
5456922
to
c1d8219
Compare
…rved in esbuild dev server Previously when using the esbuild-based browser application builder with the new dev server, resource files referenced via stylesheets may not have been served by the development server. The development server has now been adjusted to properly prioritize and serve files that were generated during the build process. Global stylesheets are also currently considered resource files as well to workaround issues with development sourcemaps within the development server itself. Global stylesheets are already fully processed by the build system prior to being passed to the development server.
…output to relative path The output option for the long-form of the assets build option should be a relative path based from the output path of the application. However, a rooted path was also considered relative to the output path. To avoid two different ways of representing the path throughout the build system. The output path is now normalized to a relative path at the beginning of the build process.
c1d8219
to
59f5fea
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Previously when using the esbuild-based browser application builder with the new dev server, resource files referenced via stylesheets may not have been served by the development server. The development server has now been adjusted to properly prioritize and serve files that were generated during the build process.
Global stylesheets are also currently considered resource files as well to workaround issues with development sourcemaps within the development server itself. Global stylesheets are already fully processed by the build system prior to being passed to the development server.