Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): ensure all build resources are served in esbuild dev server #24975

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 7, 2023

Previously when using the esbuild-based browser application builder with the new dev server, resource files referenced via stylesheets may not have been served by the development server. The development server has now been adjusted to properly prioritize and serve files that were generated during the build process.
Global stylesheets are also currently considered resource files as well to workaround issues with development sourcemaps within the development server itself. Global stylesheets are already fully processed by the build system prior to being passed to the development server.

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Apr 7, 2023
@clydin clydin changed the title fix(@angular-devkit/build-angular): ensure all build resources are server in esbuild dev server fix(@angular-devkit/build-angular): ensure all build resources are served in esbuild dev server Apr 7, 2023
@clydin clydin marked this pull request as ready for review April 7, 2023 16:36
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 7, 2023
@clydin clydin force-pushed the esbuild/dev-server-resources branch from 1f248c1 to a158dff Compare April 7, 2023 16:51
@clydin clydin requested a review from alan-agius4 April 7, 2023 17:58
@clydin clydin force-pushed the esbuild/dev-server-resources branch from a158dff to 5456922 Compare April 11, 2023 14:50
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo in the commit message and serve and such files that were generated during the build process.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2023
@clydin clydin force-pushed the esbuild/dev-server-resources branch from 5456922 to c1d8219 Compare April 12, 2023 14:03
@clydin clydin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 12, 2023
…rved in esbuild dev server

Previously when using the esbuild-based browser application builder with the new dev server,
resource files referenced via stylesheets may not have been served by the development server.
The development server has now been adjusted to properly prioritize and serve files that were
generated during the build process.
Global stylesheets are also currently considered resource files as well to workaround issues
with development sourcemaps within the development server itself. Global stylesheets are already
fully processed by the build system prior to being passed to the development server.
…output to relative path

The output option for the long-form of the assets build option should be a relative path based
from the output path of the application. However, a rooted path was also considered relative
to the output path. To avoid two different ways of representing the path throughout the build
system. The output path is now normalized to a relative path at the beginning of the build
process.
@clydin clydin force-pushed the esbuild/dev-server-resources branch from c1d8219 to 59f5fea Compare April 12, 2023 14:29
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Apr 12, 2023
@angular-robot angular-robot bot merged commit 4d8d489 into angular:main Apr 12, 2023
6 checks passed
@clydin clydin deleted the esbuild/dev-server-resources branch April 12, 2023 18:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants